This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
br/restore: add version check for backup schema_version (#929) #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Neil Shen <[email protected]>
|
/run-all-tests |
lonng
reviewed
May 11, 2021
pkg/task/restore.go
Outdated
| @@ -6,6 +6,8 @@ import ( | |||
| "context" | |||
| "time" | |||
|
|
|||
| "github.com/pingcap/br/pkg/version" | |||
|
|
|||
There was a problem hiding this comment.
Please optimize the imports.
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: f6a1646
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #929
What problem does this PR solve?
a special fix for v4.0 versions of #790
Because #685 cannot be cherry-picked to release-4.0, 4.0.x BR would corrupt 4.0 clusters without even a warn message when the backup archive come from a table with non-int clustered primary key. This PR would add a check to the backup archive version, and intercept restoring from incompatible backup archives.
What is changed and how it works?
CheckClusterVersion was changed to check version in different way.
And added a check to cluster version stored in backupmeta during restore. (after reading backup meta)
Currently, this check only checks major versions (because of clustered index).
Check List
Tests
Code changes
signature change for
CheckClusterVersion.Release Note