Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

cdclog: fix the lost ddl files (#1094) #1312

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1094

What problem does this PR solve?

Solve #870

What is changed and how it works?

ddl file use the first event's ts to build filename.
so the filter should be changed to the first event's ts < endTS

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Note

  • Fix the issue that cdclog lost some DDLs during restore.

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Jul 5, 2021
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Leavrth
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Jul 6, 2021
@3pointer
Copy link
Collaborator

3pointer commented Jul 6, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: b930a3c

@ti-chi-bot ti-chi-bot merged commit 8c6a94d into pingcap:release-4.0 Jul 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants