-
Notifications
You must be signed in to change notification settings - Fork 102
br: Ignore ddl jobs with empty query or blacklist type when exec restore #1480
Conversation
Signed-off-by: WangLe1321 <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: WangLe1321 <[email protected]>
cherry-pick pingcap/tidb#33384 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@joccau: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6790ba7
|
Signed-off-by: WangLe1321 [email protected]
What problem does this PR solve?
Issue Number: #33322
cherry-pick pingcap/tidb#33384
Problem Summary: Sometimes, query of ddl job can be empty, which will cause error when execute incremental restore.
What is changed and how it works?
During backup, when we find ddl job with action types about TiFlash or lock/unlock table, we will set the query empty. So we add an action type blacklist, ddl job with action type in blacklist will be ignored. We also ignore ddl job with empty query in case other unexpected situation.
This means that we will ignore ddl jobs about TiFlash or lock/unlock table and ddl jobs with empty query, so they won't cause error by mistake.
Check List
Tests
Code changes
Side effects
Related changes
Release note