Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

storage: increase aws maxRetries request config from 3 to 6 #583

Merged
merged 1 commit into from
Nov 6, 2020
Merged

storage: increase aws maxRetries request config from 3 to 6 #583

merged 1 commit into from
Nov 6, 2020

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

pingcap/dumpling#180

What is changed and how it works?

increase maxRetries from 3 to 6

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Possible performance regression

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • No release note

@overvenus
Copy link
Member

Please update your PR title. https://github.com/pingcap/community/blob/01457b0bba90b92a6d8f6c715a3b18cc432c6a12/contributors/commit-message-pr-style.md

overvenus
overvenus reviewed Nov 4, 2020
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test to verify if the maxRetries works as expected. Rest LGTM

@overvenus overvenus added this to the v4.0.9 milestone Nov 4, 2020
@lichunzhu lichunzhu changed the title increase maxRetries from 3 to 6 storage: increase aws maxRetries request config from 3 to 6 Nov 4, 2020
@lichunzhu
Copy link
Contributor Author

Please add a test to verify if the maxRetries works as expected. Rest LGTM

How to test this? My manual debug test can show it works. In other words, how to mock a temporary failure on minio/S3?

kennytm
kennytm reviewed Nov 4, 2020
View reviewed changes
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Nov 4, 2020
@overvenus
Copy link
Member

LGTM

@ti-srebot ti-srebot removed the status/LGT1 LGTM1 label Nov 6, 2020
@ti-srebot ti-srebot added the status/LGT2 LGTM2 label Nov 6, 2020
@kennytm kennytm merged commit caeba63 into pingcap:master Nov 6, 2020
@lichunzhu lichunzhu deleted the retryForCloudRequest branch November 23, 2020 06:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennytm kennytm kennytm left review comments

@overvenus overvenus overvenus left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@3pointer 3pointer Awaiting requested review from 3pointer

Assignees
No one assigned
Labels
status/LGT2 LGTM2
Projects
None yet
Milestone
v4.0.9
Development

Successfully merging this pull request may close these issues.
4 participants
@lichunzhu @overvenus @kennytm @ti-srebot