This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
backupmeta: add cluster_version and br_version info in backupmeta #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lichunzhu
added
component/backup
needs-cherry-pick-release-4.0
needs-cherry-pick-5.0-rc
type/feature-request
|
/run-all-tests |
|
/lgtm |
overvenus
reviewed
Feb 25, 2021
Comment on lines
+194
to
+196
| backupMeta.ClusterId = req.ClusterId | ||
| backupMeta.ClusterVersion = clusterVersion | ||
| backupMeta.BrVersion = brVersion |
There was a problem hiding this comment.
Please add a unit test to tests if these three fields are set correctly.
There was a problem hiding this comment.
addressed in 7b4365c
overvenus
reviewed
Feb 25, 2021
Comment on lines
+60
to
+62
| func (Glue) GetVersion() string { | ||
| return "BR\n" + utils.BRInfo() | ||
| } |
There was a problem hiding this comment.
Please add a unit test to make sure the version matches a certain pattern.
There was a problem hiding this comment.
addressed in 7b4365c
overvenus
reviewed
Mar 4, 2021
|
LGTM |
ti-srebot
approved these changes
Mar 4, 2021
Co-authored-by: Neil Shen <[email protected]>
|
/merge |
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Mar 4, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #803 |
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Mar 4, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-5.0-rc in PR #804 |
overvenus
pushed a commit
that referenced
this pull request
Mar 10, 2021
…) (#803) * cherry pick #734 to release-4.0 Signed-off-by: ti-srebot <[email protected]> * update kvproto tidb dependencies Co-authored-by: Chunzhu Li <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#698
What is changed and how it works?
add
cluster_versionandbr_versioninfo in backupmeta when we backup data.Check List
Tests
Code changes
Related changes
Release Note