Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

lightning/backend: run batch split region in parallel for local backend #761

Merged
merged 14 commits into from
Mar 13, 2021
Merged

lightning/backend: run batch split region in parallel for local backend #761

merged 14 commits into from
Mar 13, 2021

Conversation

glorv
Copy link
Collaborator

@glorv glorv commented Feb 26, 2021

What problem does this PR solve?

Run batch split region in parallel to speed up batch split region.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • Run batch split regions in parallel for lightning local backend

@glorv
Copy link
Collaborator Author

glorv commented Mar 9, 2021

@kennytm PTAL. I think we need to merge this pr if disk-quota is enabled because there might be multi times region split that involves more than one region.

kennytm
kennytm reviewed Mar 10, 2021
View reviewed changes
pkg/lightning/backend/localhelper.go Outdated Show resolved Hide resolved
pkg/lightning/backend/localhelper.go Outdated Show resolved Hide resolved
@glorv glorv added this to the v5.0.0 milestone Mar 10, 2021
kennytm
kennytm reviewed Mar 10, 2021
View reviewed changes
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

pkg/lightning/backend/localhelper.go Outdated Show resolved Hide resolved
pkg/lightning/backend/localhelper.go Outdated Show resolved Hide resolved
@kennytm kennytm mentioned this pull request Mar 11, 2021
Closed
@kennytm
Copy link
Collaborator

kennytm commented Mar 12, 2021

/lgtm

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Mar 12, 2021
@glorv
Copy link
Collaborator Author

glorv commented Mar 13, 2021

@lance6716 PTAL

@lance6716
Copy link
Contributor

/lgtm

@ti-srebot ti-srebot removed the status/LGT1 LGTM1 label Mar 13, 2021
@ti-srebot ti-srebot added the status/LGT2 LGTM2 label Mar 13, 2021
@glorv
Copy link
Collaborator Author

glorv commented Mar 13, 2021

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 09e9943 into pingcap:master Mar 13, 2021
ti-srebot pushed a commit to ti-srebot/br that referenced this pull request Mar 13, 2021
@glorv @ti-srebot
cherry pick pingcap#761 to release-4.0
2a91a44 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 13, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #868

@glorv glorv deleted the split-range branch March 13, 2021 08:27
ti-srebot added a commit that referenced this pull request Mar 18, 2021
@ti-srebot
lightning/backend: run batch split region in parallel for local backe…
8bc293a 
…nd (#761) (#868)

Signed-off-by: ti-srebot <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennytm kennytm kennytm left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@3pointer 3pointer Awaiting requested review from 3pointer

@Little-Wallace Little-Wallace Awaiting requested review from Little-Wallace

Assignees

@kennytm kennytm

Labels
component/import needs-cherry-pick-release-4.0 status/can-merge status/LGT2 LGTM2 type/performance
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@glorv @kennytm @lance6716 @ti-srebot