Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

pkg/lightning: fix a bug that importer backend may ignore write rows error (#835) #848

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 11, 2021

cherry-pick #835 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In br repo:
git pr https://github.com/pingcap/br/pull/848

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/br.git pr/848:release-4.0-a0b0388ee62c

What problem does this PR solve?

  • Fix a bug that importer backend may ignore write rows error when open engine returns file exists error
  • Adjust several checkpoint checks to avoid reopen index engine after the engine is closed.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • Fix the bug that importer may ignore write rows error if open engine returns file exists error

@overvenus
Copy link
Member

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Mar 11, 2021
@overvenus overvenus added this to the v4.0.12 milestone Mar 11, 2021
@kennytm
Copy link
Collaborator

kennytm commented Mar 11, 2021

/lgtm

@ti-srebot ti-srebot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Mar 11, 2021
@kennytm kennytm merged commit 2e342a1 into pingcap:release-4.0 Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants