This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 102
*: skip creating Domain for backup without stats #876
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overvenus
changed the title
*: skip creating Domain for backup withtout stats
*: skip creating Domain for backup without stats
Mar 15, 2021
overvenus
force-pushed
the
oom-remove-domain
branch
from
March 15, 2021 16:16
a39df36
to
7e394eb
Compare
Signed-off-by: Neil Shen <[email protected]>
overvenus
force-pushed
the
oom-remove-domain
branch
from
March 16, 2021 06:06
7e394eb
to
e4c22be
Compare
/run-all-tests |
1 similar comment
/run-all-tests |
Signed-off-by: Neil Shen <[email protected]>
kennytm
reviewed
Mar 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
/lgtm |
Co-authored-by: kennytm <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
/lgtm |
ti-srebot
approved these changes
Mar 17, 2021
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Mar 17, 2021
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-4.0 in PR #886 |
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Mar 17, 2021
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.0 in PR #887 |
overvenus
added a commit
that referenced
this pull request
Mar 18, 2021
Signed-off-by: ti-srebot <[email protected]> Co-authored-by: Neil Shen <[email protected]>
overvenus
added a commit
that referenced
this pull request
Mar 18, 2021
Signed-off-by: ti-srebot <[email protected]> Co-authored-by: Neil Shen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR reduces memory usage during backup by skipping initializing Domain which loads all table info into memory.
Close #818
Check List
Tests
Manual tests
The master branch BR takes about 3.09GB of memory.
This PR BR takes about 2.21G of memory.
Code changes
Related changes
Release Note