Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote mikechengwei as committer of tidb-operator #356

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

DanielZhangQD
Copy link
Contributor

@DanielZhangQD DanielZhangQD commented Nov 30, 2020

@mikechengwei has almost 30 PRs merged in the tidb-operator repo, 3 PRs merged in the docs-tidb-operator repo, and finishes the below big features by himself:

@ghost
Copy link

ghost commented Nov 30, 2020

Sig file formatting success.

Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonng
Copy link
Contributor

lonng commented Nov 30, 2020

@DanielZhangQD Please give some description of this PR.

@lonng
Copy link
Contributor

lonng commented Nov 30, 2020

@mikechengwei Congrats

@DanielZhangQD
Copy link
Contributor Author

@DanielZhangQD Please give some description of this PR.

Done.

@Rustin170506
Copy link
Member

/cc @pingcap/tidb-maintainer

@ti-chi-bot ti-chi-bot requested a review from a team November 30, 2020 06:59
@zz-jason
Copy link
Member

zz-jason commented Dec 1, 2020

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 1, 2020
@winkyao
Copy link
Contributor

winkyao commented Dec 1, 2020

/lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 1, 2020
@DanielZhangQD
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@DanielZhangQD: you cannot merge your own PR.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/ti-community-prow repository.

@winkyao
Copy link
Contributor

winkyao commented Dec 1, 2020

/merge

@Rustin170506
Copy link
Member

/assign @winkyao

/assign @zz-jason

Needs /merge.

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 1, 2020
@ti-chi-bot
Copy link
Member

Can merge label has been added.

Git tree hash: e25953d

@ti-chi-bot ti-chi-bot merged commit 73e9116 into pingcap:master Dec 1, 2020
@ghost
Copy link

ghost commented Dec 1, 2020

Update sig info success.

@DanielZhangQD DanielZhangQD deleted the comm1 branch December 1, 2020 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants