Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete command-help.md #514

Closed
wants to merge 1 commit into from
Closed

Delete command-help.md #514

wants to merge 1 commit into from

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Aug 7, 2021

sre-bot has retried. Remove outdated staff.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Mini256
Mini256 reviewed Aug 7, 2021
View reviewed changes
contributors/command-help.md

> **NOTE**: The PR must have `can merge` label.

### `/run-cherry-picker`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part may not be the time to delete, the cherry-picker of ti-srebot is still used in tidb repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. Fine.

contributors/command-help.md
#### Examples

```
/run-all-tests tidb-test=pr/666
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar commands still seem to be used, maybe we should correct it instead of deleting it.

pingcap/tidb#26876 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are not always true. I'll close this PR due to #514 (comment). But if not, I tend to delete this one and create a follow-ups PR to describe true CI commands. Or on our dev guide.

@tisonkun tisonkun closed this Aug 7, 2021
@tisonkun tisonkun deleted the tisonkun-patch-1 branch September 3, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mini256 Mini256 Mini256 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tisonkun @ti-chi-bot @Mini256