sig: merge

[tisonkun]

Signed-off-by: tison [email protected]

close #519

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• winkyao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[tisonkun]

This pull request comes from #516 and trying to build a Lightweight and GitHub Friendly Special Interest Group. We name it as team to distinguish with the original name "SIG".

The origin of these files comes from "special-interest-group" memberships.

sig	repos	original
tidb	tidb, parser, etc.	sql-infra, planner, execution, parts of migration, etc.
deployment	tidb-operator, tiup	k8s, tiup
diagnositic	tidb-dashboard	diagnositic
migration	dm, ticdc, etc.	migrate
docs	docs, docs-cn, docs-dm	docs
bigdata	tibigdata	bigdata
postgresql	as is	postgresql

• community-infra can be handled specifically as TiKV community did.
• diagnostic dropped, pingcap/tidb-dashboard can join tidb sig.
• web dropped as no activity, those repos can fallback to native GitHub collaboration.

I'd ask for all members listed here to verify whether you're still an active member or willing to mark yourself as an emeritus member so that prevent be listed as active reviewer / committer.

[lysu]

ps: does internal "bug jail group" for tidb also will be merge after this~?

[breezewish]

I propose to remove HundunDM and baurine (from sig-diagnose) since their leader privilege is mainly under TiDB Dashboard repository, instead of TiDB。

[tisonkun]

ps: does internal "bug jail group" for tidb also will be merge after this~?

I don't think so. At least I'm trying to decouple these two things. We will keep the label "sig/xxx" for a while, just it doesn't have the magic limit review / commit permission. "bug jail" can run as is since we don't change anything it depends on effectively.

[breezewish]

It would also be great if tidb-dashboard has a standalone team, considering that actual members are mostly different from TiDB's. It is not appropriate for tidb-dashboard committers to have such high privilege in tidb and its friends repositories, and vise versa.

[tisonkun]

It would also be great if tidb-dashboard has a standalone team, considering that actual members are mostly different from TiDB's. It is not appropriate for tidb-dashboard committers to have such high privilege in tidb and its friends repositories, and vise versa.

... leave the original name "diagnostic"?

[breezewish]

It would also be great if tidb-dashboard has a standalone team, considering that actual members are mostly different from TiDB's. It is not appropriate for tidb-dashboard committers to have such high privilege in tidb and its friends repositories, and vise versa.

... leave the original name "diagnostic"?

looks good!

[tisonkun]

@breeswish separated diagnostic team by 879a286

[jackysp]

Please add the members of the transaction group. They also have code to review and commit. https://github.com/orgs/pingcap/teams/transaction-committers/members @tisonkun , thanks!

[tisonkun]

@jackysp thanks for reminding me. Updated as 8fb7804

[kennytm]

@tisonkun some clarification questions on the future governance (the PR is empty on these, #516 doesn't help)

1. Are SIGs going to be removed once Teams are up?
2. All teams share the same promotion/demotion process? https://github.com/tikv/community/blob/master/GOVERNANCE.md
3. Will there still be a need for per-team regular (bi/weekly) meetings?

[tisonkun]

@kennytm thanks for your comment. I'm thinking of this and drafting a propose of governance bylaws so that we can discuss #519 and bylaws simultaneously.

Are SIGs going to be removed once Teams are up?

Yes as a governance unit. But domain experts exist objectively, their group can be named as SIG. That means we focus on purge SIG as a governance unit, but labels, slack channel remains as least for now.

All teams share the same promotion/demotion process?

Yes. In #516 it writes

Remain the consensus voting requirements. SIGs can generate their own guidelines on what they are looking for on committers etc. But hopefully we have loose requirements and contributors conclude how to become a committer by existing examples.

Also let the sig leaders moderate the whole promotion procedure.

I'm thinking of this and drafting a propose of governance bylaws so that we can discuss #519 and bylaws simultaneously, hopefully by the end of this weekend and we get a clear image.

Will there still be a need for per-team regular (bi/weekly) meetings?

No as a governance rule. If the team wants it, they can schedule by themselves, we don't require it.

[tisonkun]

@kennytm as b1dcf5a.

I'm going to join community level decision making folder, team level decision making folder, and legacy rfcs as a follow up.

[sunxiaoguang]

Great work!

LGTM

[ti-chi-bot]

@sunxiaoguang: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Great work!

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[winkyao]

LGTM

[tisonkun]

Hi audience in this thread! I'm going to merge this PR next week as two of our toc members show positive reactions.

@Mini256 after this PR merged, we're going to build the GitHub teams based on the membership files and change the lgtm plugin with reviewer_team and cmmitter_team configs. Is the prerequisite prepared?

[Mini256]

@Mini256 after this PR merged, we're going to build the GitHub teams based on the membership files and change the lgtm plugin with reviewer_team and cmmitter_team configs. Is the prerequisite prepared?

I will finish the test for the new config options this week.

[tisonkun]

@Mini256 thank you!

[tisonkun]

Hi audience in this thread,

I'm going to merge this PR now, and later will update the mechanism with help by @Mini256 .

Thanks for all of your participant.

[tisonkun]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 5697ba7