-
Notifications
You must be signed in to change notification settings - Fork 188
syncer, relay: avoid read duplicate event when retry binlog streamer #2047
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
seems an unstable test |
fixed 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weakly want to change the safe-mode behaviour
https://github.com/pingcap/dm/pull/2047/files#r699233692
tests/duplicate_event/run.sh
Outdated
cp $cur/conf/source1.yaml $WORK_DIR/source1.yaml | ||
dmctl_operate_source create $WORK_DIR/source1.yaml $SOURCE_ID1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cp $cur/conf/source1.yaml $WORK_DIR/source1.yaml | |
dmctl_operate_source create $WORK_DIR/source1.yaml $SOURCE_ID1 | |
dmctl_operate_source create $cur/conf/source1.yaml $SOURCE_ID1 |
if we don't modify $cur/conf/source1.yaml
and for source2
@lance6716 I change the |
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please remember to fix lint error
/run-all-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4b73e9c
|
In response to a cherrypick label: new pull request created: #2105. |
What problem does this PR solve?
avoiding read duplicate event in syncer and relay log.
What is changed and how it works?
ErrorMaybeDuplicateEvent
when the relay log is not complete(not end with RotateEvent).ErrorMaybeDuplicateEvent
Check List
Tests
Code changes
Side effects
Related changes