Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

master: add metrics for handle DDL #790

Merged
merged 15 commits into from
Jul 20, 2020
Merged

master: add metrics for handle DDL #790

merged 15 commits into from
Jul 20, 2020

Conversation

lance6716
Copy link
Collaborator

@lance6716 lance6716 commented Jul 8, 2020 •
edited
Loading

What problem does this PR solve?

part of #543

What is changed and how it works?

Add error counter for DDL operations, also remove TODO: add & update metrics. Mainly added for handleInfoPut and handleOperationPut.

Add panels like below

image

Check List

Tests

  • edit test case to see visual result

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

Related changes

@lance6716 lance6716 added priority/normal Minor change, requires approval from ≥1 primary reviewer status/WIP This PR is still work in progress type/feature New feature labels Jul 8, 2020
@lance6716 lance6716 mentioned this pull request Jul 8, 2020
Closed
@lance6716 lance6716 added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP This PR is still work in progress labels Jul 9, 2020
GMHDBJD
GMHDBJD reviewed Jul 14, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jul 14, 2020
@lance6716 lance6716 added the status/WIP This PR is still work in progress label Jul 16, 2020
@lance6716 lance6716 removed the status/WIP This PR is still work in progress label Jul 20, 2020
@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #790 into master will increase coverage by 0.0406%.
The diff coverage is 12.5000%.

@@               Coverage Diff                @@
##             master       #790        +/-   ##
================================================
+ Coverage   56.0909%   56.1315%   +0.0406%     
================================================
  Files           211        211                
  Lines         22082      22009        -73     
================================================
- Hits          12386      12354        -32     
+ Misses         8477       8449        -28     
+ Partials       1219       1206        -13

GMHDBJD
GMHDBJD reviewed Jul 20, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

csuzhangxc
csuzhangxc approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc removed the status/LGT1 One reviewer already commented LGTM label Jul 20, 2020
@csuzhangxc csuzhangxc added the status/LGT2 Two reviewers already commented LGTM, ready for merge label Jul 20, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC milestone Jul 20, 2020
@lance6716 lance6716 merged commit 2f1889e into pingcap:master Jul 20, 2020
@lance6716 lance6716 deleted the add-metrics branch July 20, 2020 10:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/feature New feature
Projects
None yet
Milestone
v2.0.0 RC
Development

Successfully merging this pull request may close these issues.
3 participants
@lance6716 @csuzhangxc @GMHDBJD