Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

master: add metric for worker event error #833

Merged
merged 6 commits into from
Jul 28, 2020

Conversation

lance6716
Copy link
Collaborator

@lance6716 lance6716 commented Jul 27, 2020

What problem does this PR solve?

part of #543

What is changed and how it works?

Add panel for worker event error, remove TODO.

Check List

Tests

  • Manual test (generate some error and check Grafana)
    image

Code changes

Side effects

Related changes

@lance6716 lance6716 added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/feature New feature labels Jul 27, 2020
@lance6716 lance6716 changed the title Worker event error master: add metric for worker event error Jul 27, 2020
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jul 28, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC milestone Jul 28, 2020
@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716 lance6716 merged commit 2625ba1 into pingcap:master Jul 28, 2020
@lance6716 lance6716 deleted the worker-event-error branch July 28, 2020 10:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM type/feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants