This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
*: add panel for start leader and heartbeat update error #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
added
priority/normal
Minor change, requires approval from ≥1 primary reviewer
status/PTAL
This PR is ready for review. Add this label back after committing new changes
type/dm-ansible
type/feature
New feature
labels
Aug 3, 2020
GMHDBJD
reviewed
Aug 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
GMHDBJD
added
status/LGT1
One reviewer already commented LGTM
and removed
status/PTAL
This PR is ready for review. Add this label back after committing new changes
labels
Aug 3, 2020
csuzhangxc
reviewed
Aug 4, 2020
another notice, should we need to update alert rules for newly added metrics? |
csuzhangxc
previously approved these changes
Aug 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
csuzhangxc
added
status/LGT2
Two reviewers already commented LGTM, ready for merge
and removed
status/LGT1
One reviewer already commented LGTM
labels
Aug 5, 2020
how to test alert (wip) |
csuzhangxc
reviewed
Aug 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM again. @GMHDBJD PTAL again.
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #853 +/- ##
===========================================
Coverage 56.1178% 56.1178%
===========================================
Files 220 220
Lines 22647 22647
===========================================
Hits 12709 12709
Misses 8670 8670
Partials 1268 1268 |
GMHDBJD
approved these changes
Aug 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
priority/normal
Minor change, requires approval from ≥1 primary reviewer
status/LGT2
Two reviewers already commented LGTM, ready for merge
type/feature
New feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #543 , please help me check grafana and fell free to put forward more metrics
What is changed and how it works?
add panel for number of start leader and heartbeat update error
Check List
Tests
Code changes
Side effects
Related changes