Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update information-schema-data-lock-waits.md #10438

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Update information-schema-data-lock-waits.md #10438

merged 2 commits into from
Jul 27, 2022

Conversation

longfangsong
Copy link
Contributor

@longfangsong longfangsong commented Jul 10, 2022 •
edited by TomShawn
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn July 10, 2022 16:53
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2022
@shichun-0415 shichun-0415 mentioned this pull request Jul 11, 2022
Merged
13 tasks
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 11, 2022
@TomShawn TomShawn added area/transaction Indicates that the Issue or PR belongs to the area of transaction. type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR’s assignee is translating this PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 11, 2022
@TomShawn
Copy link
Contributor

@longfangsong Is this a doc enhancement?

@Oreoxmt Oreoxmt added the v6.2 This PR/issue applies to TiDB v6.2. label Jul 11, 2022
@Oreoxmt Oreoxmt self-requested a review July 11, 2022 02:47
@longfangsong
Copy link
Contributor Author

longfangsong commented Jul 11, 2022 •
edited
Loading

@longfangsong Is this a doc enhancement?

It's a document update about an enhancement I've done on TiDB recently and planed to be released with TiDB 6.2

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jul 12, 2022

@MyonKeminta PTAL

@Oreoxmt Oreoxmt self-assigned this Jul 12, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jul 19, 2022

@longfangsong Could you please invite a tech review? Thanks~

@longfangsong
Copy link
Contributor Author

/cc @cfzjywxk

Oreoxmt
Oreoxmt reviewed Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

information-schema/information-schema-data-lock-waits.md Outdated Show resolved Hide resolved
@shichun-0415 shichun-0415 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2022
@Oreoxmt Oreoxmt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jul 21, 2022

/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 21, 2022
Oreoxmt
Oreoxmt approved these changes Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jul 27, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 15e4164

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 27, 2022
@ti-chi-bot ti-chi-bot merged commit 66ed1a0 into master Jul 27, 2022
@Oreoxmt Oreoxmt deleted the longfangsong-patch-1 branch February 2, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@TomShawn TomShawn TomShawn approved these changes

@MyonKeminta MyonKeminta MyonKeminta approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

Assignees

@longfangsong longfangsong

@Oreoxmt Oreoxmt

Labels
area/transaction Indicates that the Issue or PR belongs to the area of transaction. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement. v6.2 This PR/issue applies to TiDB v6.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@longfangsong @ti-chi-bot @TomShawn @Oreoxmt @cfzjywxk @MyonKeminta @shichun-0415