Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config, sysvar: update descriptions about instance sysvars #10978

Merged
merged 52 commits into from
Nov 1, 2022
Merged

config, sysvar: update descriptions about instance sysvars #10978

merged 52 commits into from
Nov 1, 2022

Conversation

CbcWestwolf
Copy link
Member

@CbcWestwolf CbcWestwolf commented Aug 18, 2022 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

Change descriptions about instance system variables and [instance] config items.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Aug 18, 2022
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 18, 2022
This was referenced Aug 18, 2022
Closed
Closed
@TomShawn TomShawn self-assigned this Aug 18, 2022
@TomShawn TomShawn added for-future-release This PR only applies to master for now and might cherry-pick to a future release. translation/doing This PR’s assignee is translating this PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. v6.3 This PR/issue applies to TiDB v6.3. and removed missing-translation-status This PR does not have translation status info. for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels Aug 18, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 20, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2022
@shichun-0415 shichun-0415 added for-future-release This PR only applies to master for now and might cherry-pick to a future release. v6.4 This PR/issue applies to TiDB v6.4. and removed v6.3 This PR/issue applies to TiDB v6.3. for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels Sep 13, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 6, 2022
TomShawn
TomShawn reviewed Oct 31, 2022
View reviewed changes
configure-memory-usage.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Oct 31, 2022
@qiancai qiancai removed v6.4 This PR/issue applies to TiDB v6.4. for-release This PR relates to a TiDB release but does not have a tracked feature. labels Nov 1, 2022
@TomShawn TomShawn added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 labels Nov 1, 2022
@TomShawn TomShawn removed their assignment Nov 1, 2022
@TomShawn
Copy link
Contributor

TomShawn commented Nov 1, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 50d3e43

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 1, 2022
@ti-chi-bot ti-chi-bot merged commit 53c0a7a into pingcap:master Nov 1, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 1, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11840.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 1, 2022
@CbcWestwolf @ti-chi-bot
This is an automated cherry-pick of pingcap#10978
593d552 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 1, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11841.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 1, 2022
@CbcWestwolf @ti-chi-bot
This is an automated cherry-pick of pingcap#10978
4a10400 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 1, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11842.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 1, 2022
@CbcWestwolf @ti-chi-bot
config, sysvar: update descriptions about instance sysvars (pingcap#1…
1b0a794 
…0978)
ti-chi-bot added a commit that referenced this pull request Nov 1, 2022
@ti-chi-bot
config, sysvar: update descriptions about instance sysvars (#10978) (#…
0e33f24 
…11842)
@CbcWestwolf CbcWestwolf deleted the fix_configs_sysvars branch November 1, 2022 04:20
This was referenced Nov 2, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@hfxsd hfxsd hfxsd approved these changes

@bb7133 bb7133 bb7133 approved these changes

@qiancai qiancai Awaiting requested review from qiancai

Assignees

@CbcWestwolf CbcWestwolf

Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@CbcWestwolf @ti-chi-bot @TomShawn @bb7133 @hfxsd @qiancai @shichun-0415