Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: update tidb slow log operation docs #1182

Merged
merged 11 commits into from
Apr 23, 2019

Conversation

crazycs520
Copy link
Contributor

This PR update TiDB slow log operation docs.

Cause TiDB after PR pingcap/tidb#9290, change the slow log format and change slow-log output to a file separately by default.

@crazycs520
Copy link
Contributor Author

@winkyao PTAL

sql/slow-query.md Outdated Show resolved Hide resolved
@crazycs520
Copy link
Contributor Author

@qw4990 PTAL

sql/slow-query.md Outdated Show resolved Hide resolved
@lilin90 lilin90 changed the title sql: update tidb slow log operation docs. sql: update tidb slow log operation docs Apr 22, 2019
@lilin90
Copy link
Member

lilin90 commented Apr 22, 2019

@crazycs520 Please address comments. Thanks!

sql/slow-query.md Outdated Show resolved Hide resolved
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sql/slow-query.md Outdated Show resolved Hide resolved
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 merged commit e8c62ea into pingcap:master Apr 23, 2019
op-guide/tidb-config-file.md Show resolved Hide resolved
sql/slow-query.md Show resolved Hide resolved
sql/slow-query.md Show resolved Hide resolved
sql/slow-query.md Show resolved Hide resolved
sql/slow-query.md Show resolved Hide resolved
sql/slow-query.md Show resolved Hide resolved
sql/slow-query.md Show resolved Hide resolved
sql/slow-query.md Show resolved Hide resolved
sql/slow-query.md Show resolved Hide resolved
sql/slow-query.md Show resolved Hide resolved
@lilin90
Copy link
Member

lilin90 commented Apr 24, 2019

@IzabelWang Please help address the comments of @bb7133 in a new PR and help update the corresponding English document accordingly. Thanks!

@crazycs520
Copy link
Contributor Author

@lilin90 Already address comment in new PR: #1266 and #1271

@lilin90
Copy link
Member

lilin90 commented Apr 24, 2019

@crazycs520 I see that. Thanks! But there are still some other format issues. @IzabelWang helped fix them in #1277.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants