Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Serverless Tier in Developer Guide #11862

Merged
merged 14 commits into from
Nov 8, 2022

Conversation

Icemap
Copy link
Member

@Icemap Icemap commented Nov 2, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 2, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2022
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 2, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 3, 2022
@Icemap Icemap marked this pull request as ready for review November 3, 2022 15:42
@Icemap Icemap changed the title [WIP] Adapt Serverless Tier in Developer Guide Adapt Serverless Tier in Developer Guide Nov 4, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2022
@Oreoxmt Oreoxmt added the area/develop This PR relates to the area of TiDB App development. label Nov 4, 2022
@Oreoxmt Oreoxmt requested review from Oreoxmt and removed request for TomShawn November 4, 2022 05:35
@Oreoxmt Oreoxmt added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Nov 4, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Nov 4, 2022
TOC.md Outdated Show resolved Hide resolved
develop/dev-guide-build-cluster-in-cloud.md Outdated Show resolved Hide resolved
develop/dev-guide-build-cluster-in-cloud.md Outdated Show resolved Hide resolved
develop/dev-guide-build-cluster-in-cloud.md Outdated Show resolved Hide resolved
develop/dev-guide-build-cluster-in-cloud.md Outdated Show resolved Hide resolved
Copy link
Member

@Mini256 Mini256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@Oreoxmt Oreoxmt self-requested a review November 4, 2022 07:22
@Oreoxmt Oreoxmt self-requested a review November 4, 2022 08:33
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 7, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 8, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 8, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 45dc9a5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 8, 2022
@ti-chi-bot ti-chi-bot merged commit ea0df78 into pingcap:master Nov 8, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11945.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 8, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11946.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11947.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout release-6.4: error checking out release-6.4: exit status 1. output: error: pathspec 'release-6.4' did not match any file(s) known to git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/develop This PR relates to the area of TiDB App development. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants