Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add system variable tidb_opt_range_max_size (#11239) #11921

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11239

What is changed, added or deleted? (Required)

Add system variable tidb_opt_range_max_size.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

xuyifangreeneyes and others added 26 commits November 7, 2022 02:52
Co-authored-by: shichun-0415 <[email protected]>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Nov 7, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.3 This PR is cherry-picked to release-6.3 from a source PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Nov 7, 2022
@ti-chi-bot ti-chi-bot added the v6.4 This PR/issue applies to TiDB v6.4. label Nov 7, 2022
@TomShawn
Copy link
Contributor

TomShawn commented Nov 7, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2022
@@ -2392,6 +2392,136 @@ explain select * from t where age=5;
- 默认值:`OFF`
- 指定是否允许优化器将 `Projection` 算子下推到 TiKV 或者 TiFlash。

### `tidb_opt_range_max_size` <span class="version-mark">从 v6.4.0 版本开始引入</span>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是 6.3 的分支,需要写这个变量吗

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

要改默认值

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 8, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 8, 2022
@TomShawn TomShawn removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. v6.4 This PR/issue applies to TiDB v6.4. labels Nov 8, 2022
@TomShawn
Copy link
Contributor

TomShawn commented Nov 8, 2022

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 3c3be31

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 8, 2022
@TomShawn TomShawn merged commit 13e8cb0 into pingcap:release-6.3 Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-6.3 This PR is cherry-picked to release-6.3 from a source PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants