Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for 32bits global kill #14666

Merged
merged 8 commits into from
Aug 3, 2023
Merged

Conversation

pingyu
Copy link
Collaborator

@pingyu pingyu commented Aug 1, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add docs for 32bits global kill.
See pingcap/tidb#8854 and design doc.

Preview:

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 1, 2023
Signed-off-by: Ping Yu <[email protected]>
@ran-huang ran-huang added the v7.3 This PR/issue applies to TiDB v7.3. label Aug 1, 2023
@Oreoxmt Oreoxmt self-requested a review August 1, 2023 13:51
@Oreoxmt Oreoxmt added the translation/doing This PR’s assignee is translating this PR. label Aug 1, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Aug 1, 2023
@Oreoxmt Oreoxmt added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Aug 1, 2023
pingyu and others added 2 commits August 2, 2023 10:22
Signed-off-by: Ping Yu <[email protected]>

Co-authored-by: Roger Song <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
@pingyu
Copy link
Collaborator Author

pingyu commented Aug 2, 2023

@songrijie Comments addressed, PTAL, thanks~

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 2, 2023

@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sql-statements/sql-statement-kill.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-kill.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 2, 2023
pingyu and others added 2 commits August 2, 2023 14:40
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 2, 2023
@Oreoxmt Oreoxmt added the for-release This PR relates to a TiDB release but does not have a tracked feature. label Aug 2, 2023
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 3, 2023

@Oreoxmt: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Ping Yu <[email protected]>

Co-authored-by: Aolin <[email protected]>
@Oreoxmt Oreoxmt requested a review from hfxsd August 3, 2023 06:39
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 3, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 3, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-02 07:47:40.250595134 +0000 UTC m=+257944.192943664: ☑️ agreed by Oreoxmt.
  • 2023-08-03 07:33:27.829420897 +0000 UTC m=+343491.771769427: ☑️ agreed by hfxsd.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Aug 3, 2023

/approve
/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 3, 2023
@ti-chi-bot ti-chi-bot bot merged commit fafe777 into pingcap:master Aug 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.3 This PR/issue applies to TiDB v7.3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants