Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ticdc to pulsar doc #14913

Merged
merged 43 commits into from
Sep 27, 2023
Merged

add ticdc to pulsar doc #14913

merged 43 commits into from
Sep 27, 2023

Conversation

yk133
Copy link
Contributor

@yk133 yk133 commented Aug 30, 2023 •
edited by asddongmen
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Aug 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 30, 2023

Welcome @yk133!

It looks like this is your first PR to pingcap/docs-cn 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs-cn. 😃

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 30, 2023
@hfxsd hfxsd self-assigned this Aug 30, 2023
@hfxsd hfxsd added the translation/doing This PR’s assignee is translating this PR. label Aug 30, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Aug 30, 2023
@hfxsd hfxsd added v7.4 This PR/issue applies to TiDB v7.4. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Aug 30, 2023
@hfxsd hfxsd requested a review from qiancai September 18, 2023 07:56
qiancai
qiancai reviewed Sep 19, 2023
View reviewed changes
ticdc/ticdc-sink-to-pulsar.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-pulsar.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-pulsar.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-pulsar.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-pulsar.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-pulsar.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-pulsar.md Show resolved Hide resolved
ticdc/ticdc-sink-to-pulsar.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-pulsar.md
# Pulsar 客户端发起创建、订阅等操作的超时时间，默认为 30 秒。
operation-timeout=30
# Pulsar producer 发送消息时的单个 batch 内的消息数量上限，默认值为 1000。
batching-max-messages=1000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最大可以调整为多大呢

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在没有上限。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

谢谢建议 我会想下这个问题，之后有改变我会更新文档。

ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
qiancai
qiancai approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 19, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-18 07:50:53.32643658 +0000 UTC m=+503819.294024612: ☑️ agreed by hfxsd.
  • 2023-09-19 05:42:43.633049222 +0000 UTC m=+582529.600637271: ☑️ agreed by qiancai.

@hfxsd hfxsd mentioned this pull request Sep 20, 2023
Merged
17 tasks
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 20, 2023
@hfxsd
Copy link
Collaborator

hfxsd commented Sep 27, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 27, 2023
@ti-chi-bot ti-chi-bot bot merged commit 2d6277a into pingcap:master Sep 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@asddongmen asddongmen asddongmen approved these changes

@qiancai qiancai qiancai approved these changes

@nongfushanquan nongfushanquan Awaiting requested review from nongfushanquan

Assignees

@hfxsd hfxsd

Labels
approved contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.4 This PR/issue applies to TiDB v7.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yk133 @hfxsd @asddongmen @qiancai