Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: increase the performance of loading stats #17688

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jun 14, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:

ref pingcap/docs#17895

  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 14, 2024
@qiancai qiancai added the v8.2 label Jun 14, 2024
@hfxsd hfxsd self-assigned this Jun 14, 2024
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. labels Jun 14, 2024
system-variables.md Outdated Show resolved Hide resolved
@hfxsd hfxsd changed the title *: change default value of tidb_analyze_skip_column_types *: change default value of tidb_analyze_skip_column_types Jun 14, 2024
@hfxsd hfxsd requested a review from songrijie June 14, 2024 07:10
@hfxsd hfxsd added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Jun 14, 2024
Copy link

ti-chi-bot bot commented Jun 17, 2024

@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 18, 2024
Signed-off-by: Weizhen Wang <[email protected]>
tidb-configuration-file.md Outdated Show resolved Hide resolved
@hfxsd hfxsd changed the title *: change default value of tidb_analyze_skip_column_types *: Increase the performance of loading stats Jun 18, 2024
@hfxsd hfxsd requested a review from lilin90 June 19, 2024 01:39
@lilin90 lilin90 changed the title *: Increase the performance of loading stats *: increase the performance of loading stats Jun 19, 2024
tidb-configuration-file.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 19, 2024
Copy link

ti-chi-bot bot commented Jun 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-18 01:00:50.198924053 +0000 UTC m=+76576.684412881: ☑️ agreed by hfxsd.
  • 2024-06-19 08:03:56.45037364 +0000 UTC m=+188362.935862472: ☑️ agreed by lilin90.

@hfxsd
Copy link
Collaborator

hfxsd commented Jun 28, 2024

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Jun 28, 2024
@hfxsd
Copy link
Collaborator

hfxsd commented Jun 28, 2024

/approve

Copy link

ti-chi-bot bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hfxsd
Copy link
Collaborator

hfxsd commented Jun 28, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit ca58646 into master Jun 28, 2024
6 of 7 checks passed
@ti-chi-bot ti-chi-bot bot deleted the update_tidb_analyze_skip_column_types_value branch June 28, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants