Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tune-tikv-memory-performance.md (#3817) #3869

Merged
merged 2 commits into from
Jul 3, 2020
Merged

Update tune-tikv-memory-performance.md (#3817) #3869

merged 2 commits into from
Jul 3, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #3817 to release-4.0

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@ti-srebot ti-srebot mentioned this pull request Jul 3, 2020
Merged
5 tasks
@ti-srebot ti-srebot added size/small Changes of a small size. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Jul 3, 2020
@ti-srebot ti-srebot requested a review from lilin90 July 3, 2020 06:44
yikeke
yikeke approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 3, 2020
@ti-srebot
Copy link
Contributor Author

@yikeke,Thanks for your review.

@yikeke
Copy link
Contributor

yikeke commented Jul 3, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 3, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 6ad81ab into pingcap:release-4.0 Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yikeke yikeke yikeke approved these changes

@lilin90 lilin90 Awaiting requested review from lilin90

Assignees

@yikeke yikeke

Labels
size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ti-srebot @yikeke