Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update identify-slow-queries.md&statement-summary-tables.md #3923

Merged
merged 3 commits into from
Jul 9, 2020
Merged

Update identify-slow-queries.md&statement-summary-tables.md #3923

merged 3 commits into from
Jul 9, 2020

Conversation

hidehalo
Copy link
Contributor

@hidehalo hidehalo commented Jul 8, 2020

What is changed, added or deleted?

Changed

  • identify-slow-queries.md
  • statement-summary-tables.md

Which TiDB version(s) do your changes apply to?

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@hidehalo
Update identify-slow-queries.md
726187e 
* add `Disk_max` field
@hidehalo
Update statement-summary-tables.md
3eb4f7c 
* add AVG_DISK&MAX_DISK fields
@ti-srebot ti-srebot added the contribution This PR is from a community contributor. label Jul 8, 2020
@CLAassistant
Copy link

CLAassistant commented Jul 8, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hidehalo hidehalo mentioned this pull request Jul 8, 2020
Closed
@TomShawn TomShawn added needs-cherry-pick-4.0 size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Jul 8, 2020
@TomShawn TomShawn self-requested a review July 8, 2020 12:56
@TomShawn TomShawn self-assigned this Jul 8, 2020
@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2020 •
edited
Loading

@hidehalo Thanks for your contribution! Please sign the CLA here for this PR to be merged.

djshow832
djshow832 reviewed Jul 8, 2020
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@djshow832, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

@hidehalo
Copy link
Contributor Author

hidehalo commented Jul 9, 2020

@hidehalo Thanks for your contribution! Please sign the CLA here for this PR to be merged.

@TomShawn CLA signed :D

TomShawn
TomShawn approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 9, 2020
@ti-srebot
Copy link
Contributor

@TomShawn,Thanks for your review.

@TomShawn TomShawn added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 9, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 998949a into pingcap:master Jul 9, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 9, 2020
@hidehalo @ti-srebot
cherry pick pingcap#3923 to release-4.0
090edd5 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jul 9, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3929

TomShawn pushed a commit that referenced this pull request Jul 9, 2020
@ti-srebot @hidehalo
cherry pick #3923 to release-4.0 (#3929)
ecc4e17 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: __hidehalo <[email protected]>
@TomShawn TomShawn mentioned this pull request Aug 12, 2020
Merged
9 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 12, 2020
@ti-srebot ti-srebot mentioned this pull request Aug 12, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@TomShawn TomShawn TomShawn approved these changes

@zz-jason zz-jason Awaiting requested review from zz-jason

Assignees

@TomShawn TomShawn

Labels
contribution This PR is from a community contributor. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hidehalo @CLAassistant @TomShawn @ti-srebot @djshow832