Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql-compatibility: Improve MySQL Compatibility (#4024) #4214

Merged
merged 3 commits into from
Aug 7, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #4024 to release-4.0


What is changed, added or deleted? (Required)

This improves some aspects of describing MySQL compatibility.

security issues (such as SELECT INTO OUTFILE) is not translated according to https://github.com/pingcap/docs/pull/3192/files#diff-7028919502ad5a35697a652366fdafadR12.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@ti-srebot ti-srebot added size/medium Changes of a medium size. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Aug 6, 2020
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomShawn Please refer to https://docs.pingcap.com/tidb/stable/mysql-compatibility/ and help resolve the conflicts. Thanks!

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 6, 2020
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lilin90 Conflict resolved according to the stable version of docs mysql-compatibility.md.

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Aug 7, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 6973600 into pingcap:release-4.0 Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/medium Changes of a medium size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants