Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: add more protocol in ticdc sink config #4691

Merged
merged 2 commits into from
Oct 15, 2020
Merged

ticdc: add more protocol in ticdc sink config #4691

merged 2 commits into from
Oct 15, 2020

Conversation

amyangfei
Copy link
Contributor

What is changed, added or deleted? (Required)

add more protocol in ticdc sink config

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

TomShawn
TomShawn reviewed Oct 15, 2020
View reviewed changes
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Oct 15, 2020
View reviewed changes
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
TomShawn
TomShawn approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 15, 2020
@TomShawn TomShawn added needs-cherry-pick-4.0 size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. labels Oct 15, 2020
@TomShawn TomShawn merged commit 6a11a21 into pingcap:master Oct 15, 2020
@TomShawn TomShawn self-assigned this Oct 15, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Oct 15, 2020
@amyangfei @ti-srebot
cherry pick pingcap#4691 to release-4.0
9c3e578 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Oct 15, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4693

TomShawn pushed a commit that referenced this pull request Oct 15, 2020
@ti-srebot @amyangfei
cherry pick #4691 to release-4.0 (#4693)
29c2aff 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: amyangfei <[email protected]>
@TomShawn TomShawn mentioned this pull request Oct 15, 2020
Merged
9 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Oct 15, 2020
@ti-srebot ti-srebot mentioned this pull request Oct 16, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

Assignees

@TomShawn TomShawn

Labels
size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amyangfei @ti-srebot @TomShawn