Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: correct cyclic-sync-ddl usage #4697

Merged
merged 1 commit into from
Oct 16, 2020
Merged

ticdc: correct cyclic-sync-ddl usage #4697

merged 1 commit into from
Oct 16, 2020

Conversation

overvenus
Copy link
Member

What is changed, added or deleted? (Required)

Correct cyclic-sync-ddl usage.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@overvenus
Copy link
Member Author

PTAL @amyangfei @TomShawn

amyangfei
amyangfei reviewed Oct 16, 2020
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@amyangfei, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@TomShawn TomShawn self-assigned this Oct 16, 2020
@TomShawn TomShawn added needs-cherry-pick-4.0 size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. labels Oct 16, 2020
TomShawn
TomShawn approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 16, 2020
@TomShawn TomShawn merged commit 17ab0eb into pingcap:master Oct 16, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Oct 16, 2020
@overvenus @ti-srebot
cherry pick pingcap#4697 to release-4.0
c64f116 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Oct 16, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4698

TomShawn pushed a commit that referenced this pull request Oct 16, 2020
@ti-srebot @overvenus
cherry pick #4697 to release-4.0 (#4698)
69c824f 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: Neil Shen <[email protected]>
@TomShawn TomShawn mentioned this pull request Oct 16, 2020
Merged
9 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Oct 16, 2020
@ti-srebot ti-srebot mentioned this pull request Oct 16, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei left review comments

@TomShawn TomShawn TomShawn approved these changes

Assignees

@TomShawn TomShawn

Labels
size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@overvenus @ti-srebot @amyangfei @TomShawn