Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: remove alter-primary-key configuration #5774

Merged
merged 3 commits into from
Mar 23, 2021
Merged

*: remove alter-primary-key configuration #5774

merged 3 commits into from
Mar 23, 2021

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Mar 18, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

The alter-primary-key config option is deprecated & removed in v5.0, this PR update the related documentation.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2021
@tangenta
Copy link
Contributor Author

@TomShawn This PR has the same precedence as #5771. PTAL

@tangenta
Copy link
Contributor Author

/cc @coocood @lysu

@ti-chi-bot ti-chi-bot requested review from coocood and lysu March 18, 2021 14:02
@TomShawn
Copy link
Contributor

/label needs-cherry-pick-5.0

@TomShawn
Copy link
Contributor

/status PTAL
/label require-LGT1
/assign @Joyinqin
/label v5.0
/translation doing

@ti-chi-bot ti-chi-bot added status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. require-LGT1 Indicates that the PR requires an LGTM. v5.0 This PR/issue applies to TiDB v5.0 and removed missing-translation-status This PR does not have translation status info. labels Mar 19, 2021
@lysu
Copy link
Contributor

lysu commented Mar 19, 2021

/LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lysu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 19, 2021
@TomShawn
Copy link
Contributor

Rest LGTM

@TomShawn
Copy link
Contributor

/status require-change

@ti-chi-bot ti-chi-bot added the status/require-change Needs the author to address comments. label Mar 19, 2021
@ti-srebot
Copy link
Contributor

@lysu, @coocood, PTAL.

@tangenta
Copy link
Contributor Author

/remove-label require-change

@ti-chi-bot
Copy link
Member

@tangenta: The label(s) require-change cannot be applied. These labels are supported: DNM until Ansible tag is ready, Hacktoberfest, contribution, first-time-contributor, follow-up, good-first-issue, hacktoberfest-accepted, help-wanted, needs-cherry-pick-2.1, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-master, question, require-LGT1, require-LGT2, require-LGT3, special-week, v4.0, v5.0, v6.0, version-specific-changes-required, website.

In response to this:

/remove-label require-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

/remove-status require-change
/lgtm

@ti-chi-bot ti-chi-bot removed the status/require-change Needs the author to address comments. label Mar 23, 2021
@TomShawn
Copy link
Contributor

/lgtm

@TomShawn
Copy link
Contributor

@coocood PTAL whether this PR can be merged. Thanks!

@coocood
Copy link
Member

coocood commented Mar 23, 2021

/lgtm

@ti-chi-bot
Copy link
Member

@coocood: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 283fc95

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2021
@ti-chi-bot ti-chi-bot merged commit d47fa05 into pingcap:master Mar 23, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Mar 23, 2021
@ti-srebot
cherry pick pingcap#5774 to release-5.0
91d52ce 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 23, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5794

ti-chi-bot pushed a commit that referenced this pull request Mar 24, 2021
@ti-srebot
*: remove alter-primary-key configuration (#5774) (#5794)
0934290
@tangenta tangenta mentioned this pull request Mar 25, 2021
Merged
11 tasks
@Joyinqin Joyinqin mentioned this pull request Mar 25, 2021
Merged
11 tasks
@Joyinqin
Copy link
Contributor

/translation done

@ti-chi-bot ti-chi-bot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Mar 25, 2021
@Joyinqin
Copy link
Contributor

/remove-translation doing

@ti-chi-bot ti-chi-bot removed the translation/doing This PR’s assignee is translating this PR. label Mar 25, 2021
This was referenced Mar 26, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@coocood coocood Awaiting requested review from coocood

@lysu lysu Awaiting requested review from lysu

Assignees

@Joyinqin Joyinqin

Labels
require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.0 This PR/issue applies to TiDB v5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tangenta @TomShawn @lysu @ti-chi-bot @ti-srebot @coocood @Joyinqin