Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

credits: update links to the full list of code and docs contributors #5901

Merged
merged 7 commits into from
Jul 16, 2021
Merged

credits: update links to the full list of code and docs contributors #5901

merged 7 commits into from
Jul 16, 2021

Conversation

ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Mar 31, 2021 •
edited
Loading

Signed-off-by: Ran [email protected]

What is changed, added or deleted? (Required)

  • Add a link to tidb community page.
  • Remove contributor lists.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 31, 2021
@ran-huang ran-huang marked this pull request as ready for review March 31, 2021 11:20
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2021
@ran-huang
Copy link
Contributor Author

/translation doing
/assign
/cc yikeke qiancai

@ti-chi-bot ti-chi-bot added the translation/doing This PR’s assignee is translating this PR. label Mar 31, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Mar 31, 2021
@ran-huang
Copy link
Contributor Author

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0

@ran-huang
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2021
yikeke
yikeke reviewed Apr 1, 2021
View reviewed changes
credits.md Outdated
|[planner](https://github.com/pingcap/community/tree/master/special-interest-groups/sig-planner)|[SeaRise](https://github.com/SeaRise)|
|[planner](https://github.com/pingcap/community/tree/master/special-interest-groups/sig-planner)|[tiancaiamao](https://github.com/tiancaiamao)|
|[planner](https://github.com/pingcap/community/tree/master/special-interest-groups/sig-planner)|[wshwsh12](https://github.com/wshwsh12)|
关于 TiDB 开发者社区 SIG 信息以及贡献者荣誉列表，请查阅 [SIG | TiDB DevGroup](https://developer.tidb.io/SIG/)。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

他们的页面还有什么介绍的话吗？可以多摘取些放到这里，现在这文档内容太少了。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

他们页面上主要是介绍 SIG 的，我加一些对社区不同角色的介绍吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yikeke @qiancai PTAL~

Copy link
Contributor

@yikeke yikeke Apr 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

突然觉得这个文档的性质不能叫做 credits.md 了，也不能叫做荣誉列表了，能不能想办法让内容往荣誉列表上靠呢

@yikeke
Copy link
Contributor

yikeke commented Apr 1, 2021

4.0 版本就不用改了，4.0 文档的描述没错

@ran-huang
Copy link
Contributor Author

/remove-label needs-cherry-pick-4.0

@ran-huang ran-huang changed the title credits: Add a link to tidb community page [WIP]credits: Add a link to tidb community page Apr 1, 2021
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2021
@ran-huang
Copy link
Contributor Author

/rebase

1 similar comment
@ran-huang
Copy link
Contributor Author

/rebase

@ran-huang
Copy link
Contributor Author

/sig docs sql-infra

test

@ti-chi-bot ti-chi-bot added sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. labels Apr 13, 2021
@ran-huang
Copy link
Contributor Author

/remove-sig docs sql-infra

@ti-chi-bot ti-chi-bot removed the sig/docs Indicates that the Issue or PR belongs to the docs SIG. label Apr 13, 2021
qiancai
qiancai reviewed Jul 16, 2021
View reviewed changes
credits.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 16, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b2272f5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 16, 2021
@ti-chi-bot ti-chi-bot merged commit f6545ee into pingcap:master Jul 16, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 16, 2021
Merged
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6689.

@ran-huang ran-huang deleted the credits branch July 16, 2021 08:08
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 16, 2021
Merged
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6690.

ti-chi-bot added a commit that referenced this pull request Jul 16, 2021
@ti-chi-bot
credits: update links to the full list of code and docs contributors (#…
0c48698 
…5901) (#6689)
ti-chi-bot added a commit that referenced this pull request Jul 16, 2021
@ti-chi-bot
credits: update links to the full list of code and docs contributors (#…
1d63c3c 
…5901) (#6690)
@qiancai qiancai assigned en-jin19 and unassigned ran-huang Jul 26, 2021
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@ran-huang @3AceShowHand
credits: update links to the full list of code and docs contributors (p…
bc7ad17 
…ingcap#5901)
@en-jin19 en-jin19 mentioned this pull request Aug 5, 2021
Merged
11 tasks
@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 5, 2021
This was referenced Aug 30, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yikeke yikeke yikeke left review comments

@TomShawn TomShawn TomShawn approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@en-jin19 en-jin19

Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ran-huang @yikeke @qiancai @ti-chi-bot @TomShawn @en-jin19