Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add notice about scaling in pd node #6514

Merged
merged 6 commits into from
Jul 15, 2021
Merged

add notice about scaling in pd node #6514

merged 6 commits into from
Jul 15, 2021

Conversation

AstroProfundis
Copy link
Contributor

@AstroProfundis AstroProfundis commented Jun 23, 2021 •
edited by TomShawn
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add a notice about scaling PD nodes, this is the same as in "scale tidb cluster with Ansible" document.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions) version specific for 4.0.3
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@AstroProfundis AstroProfundis self-assigned this Jun 23, 2021
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 23, 2021
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Jun 24, 2021
@TomShawn TomShawn self-requested a review June 24, 2021 03:01
lilyjazz
lilyjazz reviewed Jul 1, 2021
View reviewed changes
scale-tidb-using-tiup.md Outdated
@@ -234,6 +234,10 @@ tiup cluster display <cluster-name>
>
> 移除 TiDB、PD 节点和移除 TiKV 节点的步骤类似。

> **注意：**
>
> TiKV 中的 PD Client 会缓存 PD 节点列表，但目前不会定期自动更新，只有在 PD leader 发生切换或 TiKV 重启加载最新配置后才会更新；为避免 TiKV 缓存的 PD 节点列表过旧的风险，在扩缩容 PD 完成后，PD 集群中应至少包含两个扩缩容操作前就已经存在的 PD 节点成员，如果不满足该条件需要手动执行 PD transfer leader 操作，更新 TiKV 中的 PD 缓存列表。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rleungx 为什么「在扩缩容完成后，至少包含 2 个扩缩容操作前就已经存在的 PD 节点成员」啊～我看这篇文档的示例中，PD 就只有 1 个节点。会不会造成误解？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @AstroProfundis BTW, we need to specify the version of this warning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the version affected?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost all versions before v.4.0.3 and we introduce a new mechanism to reduce the probability after v4.0.3

@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Jul 5, 2021
@TomShawn TomShawn requested a review from lilyjazz July 6, 2021 05:07
@TomShawn TomShawn added status/PTAL This PR is ready for reviewing. and removed status/require-change Needs the author to address comments. labels Jul 6, 2021
TomShawn
TomShawn reviewed Jul 7, 2021
View reviewed changes
scale-tidb-using-tiup.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added type/enhancement The issue or PR belongs to an enhancement. and removed needs-cherry-pick-release-4.0 labels Jul 14, 2021
@TomShawn
Copy link
Contributor

/rebase

@TomShawn TomShawn added needs-cherry-pick-release-4.0 requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Jul 15, 2021
rleungx
rleungx reviewed Jul 15, 2021
View reviewed changes
scale-tidb-using-tiup.md Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

@rleungx: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2021
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 15, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ee0ea37

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2021
@ti-chi-bot ti-chi-bot merged commit 4b19b9a into pingcap:master Jul 15, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 15, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6678.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 15, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6679.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 15, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6680.

ti-chi-bot added a commit that referenced this pull request Jul 15, 2021
@ti-chi-bot
add notice about scaling in pd node (#6514) (#6680)
6d31f41
ti-chi-bot added a commit that referenced this pull request Jul 15, 2021
@ti-chi-bot
add notice about scaling in pd node (#6514) (#6679)
2980557
ti-chi-bot added a commit that referenced this pull request Jul 15, 2021
@ti-chi-bot
add notice about scaling in pd node (#6514) (#6678)
317ab33
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@AstroProfundis @3AceShowHand
add notice about scaling in pd node (pingcap#6514)
aa3d413
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Aug 4, 2021
Merged
11 tasks
@Liuxiaozhen12 Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 4, 2021
This was referenced Aug 23, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@rleungx rleungx rleungx approved these changes

@lilyjazz lilyjazz Awaiting requested review from lilyjazz

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels
requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AstroProfundis @TomShawn @ti-chi-bot @lilyjazz @rleungx @Liuxiaozhen12