Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tune TiKV: change the default value of grpc-concurrency #7139

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Tune TiKV: change the default value of grpc-concurrency #7139

merged 1 commit into from
Sep 24, 2021

Conversation

en-jin19
Copy link
Contributor

@en-jin19 en-jin19 commented Sep 15, 2021 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

Changed the default value of server.grpc-concurrency from 4 to 5 in "tune-tikv-thread-performance.md" according to "tikv-configuration-file.md".

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s): #7088

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@en-jin19 en-jin19 added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-4.0 sig/docs Indicates that the Issue or PR belongs to the docs SIG. labels Sep 15, 2021
@en-jin19 en-jin19 self-assigned this Sep 15, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 15, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 15, 2021
@en-jin19 en-jin19 added the area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. label Sep 15, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 24, 2021
@TomShawn TomShawn added the type/bugfix This PR fixes a bug. label Sep 24, 2021
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 24, 2021
@TomShawn TomShawn linked an issue Sep 24, 2021 that may be closed by this pull request
关于 TiKV 性能调优文档中 grpc-concurrency 默认值的问题 #7088
Closed
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9d072a5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 24, 2021
@ti-chi-bot ti-chi-bot merged commit 0566107 into pingcap:master Sep 24, 2021
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Sep 24, 2021
@en-jin19 @ti-chi-bot
This is an automated cherry-pick of pingcap#7139
c1372e9 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 24, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7167.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Sep 24, 2021
@en-jin19 @ti-chi-bot
This is an automated cherry-pick of pingcap#7139
db0bc61 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 24, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7168.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 24, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7169.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Sep 24, 2021
@en-jin19 @ti-chi-bot
This is an automated cherry-pick of pingcap#7139
3498be6 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 24, 2021
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7170.

@en-jin19 en-jin19 mentioned this pull request Sep 24, 2021
Merged
12 tasks
@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 24, 2021
ti-chi-bot added a commit that referenced this pull request Sep 26, 2021
@ti-chi-bot
Tune TiKV: change the default value of grpc-concurrency (#7139) (#7169
ecf19f2 
)
ti-chi-bot added a commit that referenced this pull request Sep 26, 2021
@ti-chi-bot
Tune TiKV: change the default value of grpc-concurrency (#7139) (#7167
8192ac0 
)
ti-chi-bot added a commit that referenced this pull request Sep 26, 2021
@ti-chi-bot
Tune TiKV: change the default value of grpc-concurrency (#7139) (#7168
442cec2 
)
This was referenced Sep 26, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@Connor1996 Connor1996 Awaiting requested review from Connor1996

Assignees

@en-jin19 en-jin19

Labels
area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

关于 TiKV 性能调优文档中 grpc-concurrency 默认值的问题
3 participants
@en-jin19 @ti-chi-bot @TomShawn