sql: add default differences between TiDB and MySQL #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilin90
reviewed
Aug 31, 2018
sql/mysql-compatibility.md
Outdated
| + MySQL 中默认设置： | ||
| + Linux 系统中该值为 0 | ||
| + Windows 系统中该值为 1 | ||
| + macOS 系统中该值为 2 |
There was a problem hiding this comment.
For this newly added section, please remove the Chinese period of each sentence in the list. It seems that it looks better that way.
|
LGTM |
tiancaiamao
approved these changes
Sep 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via: pingcap/docs#591
Comment addressed. PTAL again. @lilin90