Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ticdc-avro-protocol.md #9449

Merged
merged 16 commits into from
May 27, 2022
Merged

Conversation

zhangyangyu
Copy link
Member

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)

What is the related PR or file link(s)?

ref pingcap/tiflow#5338

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 12, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn May 12, 2022 17:52
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 12, 2022
@TomShawn TomShawn added type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR’s assignee is translating this PR. area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. and removed missing-translation-status This PR does not have translation status info. labels May 13, 2022
@shichun-0415 shichun-0415 added the v6.1 This PR/issue applies to TiDB v6.1. label May 13, 2022
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 24, 2022
@shichun-0415 shichun-0415 requested a review from qiancai May 24, 2022 12:13
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 26, 2022
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 27, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 71e55bb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2022
@shichun-0415 shichun-0415 merged commit 43b11ea into pingcap:master May 27, 2022
@zhangyangyu zhangyangyu deleted the avro-protocol branch August 10, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement. v6.1 This PR/issue applies to TiDB v6.1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants