Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed format_version default value to 4 #9507

Merged
merged 3 commits into from
May 20, 2022
Merged

Changed format_version default value to 4 #9507

merged 3 commits into from
May 20, 2022

Conversation

jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented May 17, 2022 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

  • Changed format_version default value to 4.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label May 17, 2022
@ti-chi-bot ti-chi-bot requested a review from TomShawn May 17, 2022 08:31
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2022
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. v6.1 This PR/issue applies to TiDB v6.1. and removed missing-translation-status This PR does not have translation status info. labels May 17, 2022
@TomShawn
Copy link
Contributor

@jiaqizho Could you please invite a technical reviewer? Thanks!

@TomShawn TomShawn added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label May 17, 2022
@TomShawn TomShawn requested review from shichun-0415 and removed request for TomShawn May 17, 2022 09:03
@shichun-0415 shichun-0415 mentioned this pull request May 17, 2022
Merged
14 tasks
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 17, 2022
shichun-0415
shichun-0415 approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 20, 2022
@shichun-0415
Copy link
Contributor

/verify

JaySon-Huang
JaySon-Huang approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shichun-0415
Copy link
Contributor

/remove status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label May 20, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3c91271

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 20, 2022
@ti-chi-bot ti-chi-bot merged commit dacda64 into master May 20, 2022
@shichun-0415 shichun-0415 deleted the tiflash-6.1-doc-update branch May 20, 2022 11:50
flowbehappy added a commit that referenced this pull request Jun 7, 2022
@flowbehappy
Revert "Changed format_version default value to 4 (#9507)"
552cec7 
TiFlash v6.1 by default use `format_version = 3`.
ti-chi-bot pushed a commit that referenced this pull request Jun 8, 2022
@flowbehappy
Revert "Changed format_version default value to 4 (#9507)" (#9705)
741aa95
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jun 8, 2022
@flowbehappy @ti-chi-bot
Revert "Changed format_version default value to 4 (pingcap#9507)"
269d6e8 
TiFlash v6.1 by default use `format_version = 3`.
ti-chi-bot added a commit that referenced this pull request Jun 8, 2022
@ti-chi-bot
Revert "Changed format_version default value to 4 (#9507)" (#9705) (#…
9b67798 
…9706)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

Assignees

@shichun-0415 shichun-0415

Labels
area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.1 This PR/issue applies to TiDB v6.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jiaqizho @ti-chi-bot @TomShawn @shichun-0415 @JaySon-Huang