Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete a limitation description #9651

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Conversation

lilyjazz
Copy link
Member

@lilyjazz lilyjazz commented Jun 2, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

we fix a bug so we can ignore the limitation: "Top SQL 在该版本中不支持统计那些开启 Top SQL 功能前就已在运行、当前仍然还在运行中的 SQL 语句的 CPU 开销情况。因此,建议尽早开启 Top SQL 功能,而非等到已经遇到了性能问题再开启。"
fix pr: pingcap/tidb#33861

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

we fix a bug so we can ignore the limitation: "Top SQL 在该版本中不支持统计那些开启 Top SQL 功能前就已在运行、当前仍然还在运行中的 SQL 语句的 CPU 开销情况。因此,建议尽早开启 Top SQL 功能,而非等到已经遇到了性能问题再开启。"
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 2, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breezewish
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn June 2, 2022 02:51
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 2, 2022
@lilyjazz
Copy link
Member Author

lilyjazz commented Jun 2, 2022

@zhongzc @breezewish PTAL

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2022
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 2, 2022
@shichun-0415 shichun-0415 requested a review from qiancai June 2, 2022 03:36
@shichun-0415 shichun-0415 added translation/doing This PR’s assignee is translating this PR. area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. and removed missing-translation-status This PR does not have translation status info. labels Jun 2, 2022
@shichun-0415 shichun-0415 added the v6.1 This PR/issue applies to TiDB v6.1. label Jun 2, 2022
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 2, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8ec95b9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 2, 2022
@qiancai qiancai assigned lilyjazz and unassigned qiancai Jun 2, 2022
@ti-chi-bot ti-chi-bot merged commit b284956 into pingcap:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.1 This PR/issue applies to TiDB v6.1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants