-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete a limitation description #9651
Conversation
we fix a bug so we can ignore the limitation: "Top SQL 在该版本中不支持统计那些开启 Top SQL 功能前就已在运行、当前仍然还在运行中的 SQL 语句的 CPU 开销情况。因此,建议尽早开启 Top SQL 功能,而非等到已经遇到了性能问题再开启。"
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@zhongzc @breezewish PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8ec95b9
|
First-time contributors' checklist
What is changed, added or deleted? (Required)
we fix a bug so we can ignore the limitation: "Top SQL 在该版本中不支持统计那些开启 Top SQL 功能前就已在运行、当前仍然还在运行中的 SQL 语句的 CPU 开销情况。因此,建议尽早开启 Top SQL 功能,而非等到已经遇到了性能问题再开启。"
fix pr: pingcap/tidb#33861
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?