Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TiDB] Add a new mode prefer-leader for replica_read_mode. #12337

Merged
merged 4 commits into from
Feb 10, 2023
Merged

[TiDB] Add a new mode prefer-leader for replica_read_mode. #12337

merged 4 commits into from
Feb 10, 2023

Conversation

LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Feb 1, 2023 •
edited
Loading

Signed-off-by: Lucasliang [email protected]

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add a new mode prefer-leader for the system variable replica_read_mode.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 1, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 1, 2023
@LykxSassinator LykxSassinator mentioned this pull request Feb 1, 2023
Merged
15 tasks
@TomShawn TomShawn added translation/doing This PR's assignee is translating this PR. v6.6 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. and removed missing-translation-status This PR does not have translation status info. translation/doing This PR's assignee is translating this PR. labels Feb 1, 2023
@LykxSassinator
Polish docs.
95b75a4 
Signed-off-by: Lucasliang <[email protected]>
TomShawn
TomShawn reviewed Feb 3, 2023
View reviewed changes
follower-read.md Outdated Show resolved Hide resolved
TomShawn
TomShawn approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 3, 2023
@TomShawn
Copy link
Contributor

TomShawn commented Feb 3, 2023

/verify

@LykxSassinator LykxSassinator mentioned this pull request Feb 7, 2023
Merged
12 tasks
@LykxSassinator
Copy link
Contributor Author

@TomShawn As all related PRs merged, this pr can be merged now.

@TomShawn
Copy link
Contributor

TomShawn commented Feb 9, 2023

Details

This PR needs approval by @easonn7.

@LykxSassinator
Copy link
Contributor Author

LykxSassinator commented Feb 9, 2023 •
edited
Loading

Details

This PR needs approval by @easonn7.

cc @TomShawn. The related PR: pingcap/docs-cn#12865 has been approved.

@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 10, 2023
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 32ff9fb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 10, 2023
@ti-chi-bot ti-chi-bot merged commit 6410cbf into pingcap:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

Assignees

@LykxSassinator LykxSassinator

@TomShawn TomShawn

Labels
area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LykxSassinator @ti-chi-bot @TomShawn