Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reference/sql/functions-and-operators: update list #1262

Merged
merged 4 commits into from
Jun 25, 2019
Merged

reference/sql/functions-and-operators: update list #1262

merged 4 commits into from
Jun 25, 2019

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Jun 25, 2019 •
edited by lilin90
Loading

What is changed, added or deleted?

Make it clearer what is supported versus not supported. Fixes #672

I have left the 2.1 docs in the old format, since the supported list differs -- and it's a lot of work to keep this up to date.

Also fixes #960

What is the related PR or file link(s)?

Two issues fixed in #1281 and #1284 by @yikeke.

Which version does your change affect?

3.0 and dev

Check list

  • Add a new file to TOC.md
  • No Tab spaces anywhere
  • Leave a blank line both before and after a code block
  • Keep the first level heading consistent with title in metadata
  • Use four spaces for each level of indentation except that in TOC.md

@morgo
reference/sql/functions-and-operators: update list
6393f33 
Make it clearer what is supported versus not supported.
Based on pingcap#672
@morgo morgo mentioned this pull request Jun 25, 2019
Closed
11 tasks
@morgo morgo requested a review from dcalvin June 25, 2019 02:07
@morgo morgo added dev labels Jun 25, 2019
dcalvin
dcalvin approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@dcalvin dcalvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgo morgo merged commit 647696a into pingcap:master Jun 25, 2019
@morgo morgo deleted the update-functions branch June 25, 2019 13:08
@lilin90
Copy link
Member

lilin90 commented Jun 27, 2019 •
edited
Loading

The ^[[200~ characters in Functions only available in MySQL Enterprise [Issue #2632](^[[200~https://github.com/pingcap/tidb/issues/2632) caused PDF build failure. Now it has been fixed in #1281 and #1284.

@lilin90 lilin90 added the translation/doing This PR's assignee is translating this PR. label Aug 7, 2019
@yikeke yikeke mentioned this pull request Aug 9, 2019
Merged
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Aug 9, 2019
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalvin dcalvin dcalvin approved these changes

Assignees

@yikeke yikeke

Labels
contribution This PR is from a community contributor. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BENCHMARK function is missing Add a list of unsupported functions
5 participants
@morgo @lilin90 @dcalvin @sre-bot @yikeke