Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added COALESCE PARTITION #13162

Merged
merged 28 commits into from
Apr 25, 2023
Merged

Added COALESCE PARTITION #13162

merged 28 commits into from
Apr 25, 2023

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Apr 6, 2023

What is changed, added or deleted? (Required)

Added documentation for COALESCE PARTITION and ADD PARTITION for Hash/Key partitioned tables.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 6, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 6, 2023
@qiancai qiancai added v7.1 This PR/issue applies to TiDB v7.1. translation/doing This PR's assignee is translating this PR. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. labels Apr 6, 2023
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Apr 6, 2023
@qiancai qiancai self-requested a review April 6, 2023 10:12
@qiancai qiancai self-assigned this Apr 6, 2023
partitioned-table.md Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved

Result:
```sql
SHOW CREATE TABLE\G
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the statememt to SHOW CREATE TABLE example;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is still correct.

partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
mysql-compatibility.md Outdated Show resolved Hide resolved
mysql-compatibility.md Outdated Show resolved Hide resolved
glossary.md Outdated Show resolved Hide resolved
glossary.md Outdated Show resolved Hide resolved
mjonss and others added 2 commits April 17, 2023 16:55
partitioned-table.md Outdated Show resolved Hide resolved
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mysql-compatibility.md Outdated Show resolved Hide resolved
mysql-compatibility.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

partitioned-table.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 18, 2023
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
glossary.md Outdated Show resolved Hide resolved
partitioned-table.md Show resolved Hide resolved
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 18, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 25, 2023
@qiancai
Copy link
Collaborator

qiancai commented Apr 25, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 25, 2023

This pull request has been accepted and is ready to merge.

Commit hash: d484da8

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2023
@ti-chi-bot ti-chi-bot bot merged commit 769dbb0 into pingcap:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v7.1 This PR/issue applies to TiDB v7.1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants