Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

develop: update env file code examples #16612

Merged
merged 2 commits into from
Feb 29, 2024
Merged

develop: update env file code examples #16612

merged 2 commits into from
Feb 29, 2024

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Feb 27, 2024 •
edited
Loading

What is changed, added or deleted? (Required)

Update the .env code examples in develop/ to keep the style consistent with other files.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/develop This PR relates to the area of TiDB App development. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.4 needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Feb 27, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 27, 2024
@hfxsd hfxsd self-requested a review February 29, 2024 06:33
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 29, 2024
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Feb 29, 2024

/cc @Mini256

@ti-chi-bot ti-chi-bot bot requested a review from Mini256 February 29, 2024 06:52
Mini256
Mini256 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@Mini256 Mini256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please describe it clearly in the PR title

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 29, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-29 06:45:34.509867004 +0000 UTC m=+1117223.257490110: ☑️ agreed by hfxsd.
  • 2024-02-29 09:37:38.925291136 +0000 UTC m=+1127547.672914250: ☑️ agreed by Mini256.

@Oreoxmt Oreoxmt changed the title Update dev-guide-sample-application-nodejs-prisma.md develop: update env file code examples Feb 29, 2024
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Feb 29, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 29, 2024
@ti-chi-bot ti-chi-bot bot merged commit 528dc73 into pingcap:master Feb 29, 2024
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #16643.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 29, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #16644.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Feb 29, 2024
@Oreoxmt @ti-chi-bot
This is an automated cherry-pick of pingcap#16612
4c9251f 
Signed-off-by: ti-chi-bot <[email protected]>
This was referenced Feb 29, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16645.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #16646.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 29, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #16647.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Feb 29, 2024
@Oreoxmt @ti-chi-bot
This is an automated cherry-pick of pingcap#16612
66cba8c 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 29, 2024
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Mar 1, 2024
@ti-chi-bot
develop: update env file code examples (#16612) (#16643)
557e1c2
ti-chi-bot bot pushed a commit that referenced this pull request Mar 1, 2024
@ti-chi-bot
develop: update env file code examples (#16612) (#16647)
0ddadad
ti-chi-bot bot pushed a commit that referenced this pull request Mar 1, 2024
@ti-chi-bot
develop: update env file code examples (#16612) (#16644)
3cbd5b3
ti-chi-bot bot pushed a commit that referenced this pull request Mar 1, 2024
@ti-chi-bot
develop: update env file code examples (#16612) (#16645)
4c8db23
ti-chi-bot bot pushed a commit that referenced this pull request Mar 1, 2024
@ti-chi-bot
develop: update env file code examples (#16612) (#16646)
bdc8396
@Oreoxmt Oreoxmt deleted the translate/docs-cn-16135 branch July 10, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mini256 Mini256 Mini256 approved these changes

@hfxsd hfxsd hfxsd approved these changes

Assignees
No one assigned
Labels
approved area/develop This PR relates to the area of TiDB App development. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Oreoxmt @ti-chi-bot @Mini256 @hfxsd