Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql-statement-explain: add explanation related to scalar subquery #19019

Merged
merged 6 commits into from
Sep 30, 2024

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Sep 30, 2024

What is changed, added or deleted? (Required)

As the title says.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Sep 30, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 30, 2024
Copy link

ti-chi-bot bot commented Sep 30, 2024

@time-and-fate: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 30, 2024
Copy link

ti-chi-bot bot commented Sep 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-30 10:59:12.457069581 +0000 UTC m=+266107.877282587: ☑️ agreed by hfxsd.

@qiancai qiancai added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. lgtm labels Sep 30, 2024
@qiancai
Copy link
Collaborator Author

qiancai commented Sep 30, 2024

/approve

Copy link

ti-chi-bot bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 30, 2024
@ti-chi-bot ti-chi-bot bot merged commit 7a22beb into pingcap:master Sep 30, 2024
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #19026.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #19027.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #19028.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants