Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add auto-increment.md #2776

Merged
merged 8 commits into from
Jun 15, 2020
Merged

add auto-increment.md #2776

merged 8 commits into from
Jun 15, 2020

Conversation

ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Jun 10, 2020

What is changed, added or deleted? (Required)

Add auto-increment.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@ran-huang ran-huang marked this pull request as ready for review June 11, 2020 06:36
@ran-huang ran-huang added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 labels Jun 11, 2020
@ran-huang
Copy link
Contributor Author

@tangenta I notice that you didn't tick v4.0 in the Chinese PR (pingcap/docs-cn#3163). Please help check whether the English version of auto-increment.md applies to 4.0. Thanks!

@yikeke yikeke requested review from TomShawn and removed request for yikeke June 11, 2020 07:57
@yikeke
Copy link
Contributor

yikeke commented Jun 11, 2020

Please help review this PR, thanks~ @TomShawn

@TomShawn
Copy link
Contributor

Please help review this PR, thanks~ @TomShawn

OK

@tangenta
Copy link
Contributor

@tangenta I notice that you didn't tick v4.0 in the Chinese PR (pingcap/docs-cn#3163). Please help check whether the English version of auto-increment.md applies to 4.0. Thanks!

Yes, both of the Chinese and the English versions of auto-increment.md are applicable to release-4.0.

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

auto-increment.md Outdated Show resolved Hide resolved
auto-increment.md Outdated Show resolved Hide resolved
@yikeke yikeke self-requested a review June 11, 2020 10:06
auto-increment.md Outdated Show resolved Hide resolved
auto-increment.md Outdated Show resolved Hide resolved
auto-increment.md Outdated Show resolved Hide resolved
auto-increment.md Outdated Show resolved Hide resolved
auto-increment.md Outdated Show resolved Hide resolved
auto-increment.md Outdated Show resolved Hide resolved
auto-increment.md Outdated Show resolved Hide resolved
auto-increment.md Outdated Show resolved Hide resolved
auto-increment.md Outdated Show resolved Hide resolved
auto-increment.md Outdated Show resolved Hide resolved
@ran-huang
Copy link
Contributor Author

@TomShawn PTAL, thanks~

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 15, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 0e677b5 into pingcap:master Jun 15, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 15, 2020
@ti-srebot ti-srebot mentioned this pull request Jun 15, 2020
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #2870

ti-srebot added a commit that referenced this pull request Jun 15, 2020
@ran-huang ran-huang deleted the auto_increment branch June 15, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants