Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error-codes.md #3336

Merged
merged 12 commits into from
Jul 27, 2020
Merged

Update error-codes.md #3336

merged 12 commits into from
Jul 27, 2020

Conversation

ireneontheway
Copy link
Contributor

What is changed, added or deleted? (Required)

Update error-codes.md to include missing error codes.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@ireneontheway
Copy link
Contributor Author

/label size/medium,special-week,translation/from-docs-cn,needs-cherry-pick-4.0

@ti-srebot ti-srebot added needs-cherry-pick-4.0 size/medium Changes of a medium size. special-week PR from Document Special Week. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jul 20, 2020
@ireneontheway
Copy link
Contributor Author

@yikeke PTAL

@yikeke yikeke requested review from yikeke and bobotu July 20, 2020 07:55
@yikeke
Copy link
Contributor

yikeke commented Jul 20, 2020

Please fix the three dead anchors first.

ireneontheway
ireneontheway commented Jul 20, 2020
View reviewed changes
error-codes.md Outdated
@@ -451,12 +431,6 @@ In addition, TiDB has the following unique error codes:

Extend the interval of GC Life Time.

* Error Number: 9500
Copy link
Contributor Author

@ireneontheway ireneontheway Jul 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not show in pingcap/docs-cn#3160. @yikeke

@yikeke
Copy link
Contributor

yikeke commented Jul 20, 2020

/uncc yikeke,bobotu

@yikeke
Copy link
Contributor

yikeke commented Jul 20, 2020

/cc yikeke,bobotu

@ti-srebot ti-srebot requested review from bobotu and yikeke July 20, 2020 09:06
@yikeke
Copy link
Contributor

yikeke commented Jul 20, 2020

/cc lilin90

@ti-srebot ti-srebot requested a review from lilin90 July 20, 2020 09:09
@yikeke
Copy link
Contributor

yikeke commented Jul 20, 2020

/uncc @lilin90

@ti-srebot ti-srebot removed the request for review from lilin90 July 20, 2020 09:09
yikeke
yikeke reviewed Jul 21, 2020
View reviewed changes
error-codes.md Outdated Show resolved Hide resolved
error-codes.md Outdated Show resolved Hide resolved
yikeke
yikeke reviewed Jul 22, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM. Good job!

error-codes.md Outdated Show resolved Hide resolved
error-codes.md Outdated Show resolved Hide resolved
error-codes.md Outdated Show resolved Hide resolved
error-codes.md Outdated Show resolved Hide resolved
error-codes.md Outdated Show resolved Hide resolved
error-codes.md Outdated Show resolved Hide resolved
error-codes.md Outdated Show resolved Hide resolved
error-codes.md Outdated Show resolved Hide resolved
error-codes.md Outdated Show resolved Hide resolved
@ireneontheway
Copy link
Contributor Author

PTAL @yikeke

@ireneontheway @yikeke
Update error-codes.md
fb8fae9 
Co-authored-by: Keke Yi <[email protected]>
yikeke
yikeke approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 24, 2020
@ireneontheway
Copy link
Contributor Author

@bobotu PTAL

bobotu
bobotu reviewed Jul 27, 2020
View reviewed changes
Copy link

@bobotu bobotu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@bobotu,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@yikeke yikeke added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 27, 2020
@yikeke
Copy link
Contributor

yikeke commented Jul 27, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 27, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 89ea93a into pingcap:master Jul 27, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 27, 2020
@ireneontheway @ti-srebot
cherry pick pingcap#3336 to release-4.0
2d15515 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jul 27, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3419

ireneontheway added a commit that referenced this pull request Jul 27, 2020
@ti-srebot @ireneontheway
cherry pick #3336 to release-4.0 (#3419)
ea92d9a 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: ireneontheway <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobotu bobotu bobotu left review comments

@yikeke yikeke yikeke approved these changes

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/medium Changes of a medium size. special-week PR from Document Special Week. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ireneontheway @yikeke @ti-srebot @bobotu