Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update user-account-management.md #3428

Merged
merged 5 commits into from
Jul 31, 2020
Merged

Update user-account-management.md #3428

merged 5 commits into from
Jul 31, 2020

Conversation

ireneontheway
Copy link
Contributor

@ireneontheway ireneontheway commented Jul 27, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ireneontheway ireneontheway added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 special-week PR from Document Special Week. labels Jul 27, 2020
@ireneontheway ireneontheway added the status/PTAL This PR is ready for reviewing. label Jul 27, 2020
tiancaiamao
tiancaiamao reviewed Jul 27, 2020
View reviewed changes
user-account-management.md Outdated Show resolved Hide resolved
user-account-management.md Outdated Show resolved Hide resolved
user-account-management.md Outdated Show resolved Hide resolved
user-account-management.md Outdated Show resolved Hide resolved
yikeke
yikeke reviewed Jul 28, 2020
View reviewed changes
user-account-management.md Outdated Show resolved Hide resolved
user-account-management.md Outdated Show resolved Hide resolved
user-account-management.md Outdated Show resolved Hide resolved
user-account-management.md Outdated Show resolved Hide resolved
user-account-management.md Outdated Show resolved Hide resolved
user-account-management.md Outdated Show resolved Hide resolved
user-account-management.md Outdated Show resolved Hide resolved
user-account-management.md Outdated Show resolved Hide resolved
user-account-management.md Outdated Show resolved Hide resolved
user-account-management.md Outdated Show resolved Hide resolved
yikeke
yikeke approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 28, 2020
@yikeke
Copy link
Contributor

yikeke commented Jul 28, 2020

PTAL again @tiancaiamao

@ti-srebot
Copy link
Contributor

@tiancaiamao, @yikeke, PTAL.

@tiancaiamao
Copy link
Contributor

LGTM

@ti-srebot
Copy link
Contributor

@tiancaiamao,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@ireneontheway ireneontheway merged commit b7ef546 into pingcap:master Jul 31, 2020
@ireneontheway ireneontheway deleted the user-account-management branch July 31, 2020 02:21
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 31, 2020
@ireneontheway @ti-srebot
cherry pick pingcap#3428 to release-4.0
ac5e628 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jul 31, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3491

ireneontheway added a commit that referenced this pull request Jul 31, 2020
@ti-srebot @ireneontheway
cherry pick #3428 to release-4.0 (#3491)
0df0a6f 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: ireneontheway <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao left review comments

@yikeke yikeke yikeke approved these changes

Assignees
No one assigned
Labels
special-week PR from Document Special Week. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ireneontheway @yikeke @ti-srebot @tiancaiamao