Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update GC for release 5.0 #4485

Merged
merged 9 commits into from
Dec 28, 2020
Merged

update GC for release 5.0 #4485

merged 9 commits into from
Dec 28, 2020

Conversation

CharLotteiu
Copy link
Contributor

@CharLotteiu CharLotteiu commented Dec 24, 2020 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

Add GC in Compaction Filter mechanism for release 5.0

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@CharLotteiu CharLotteiu added status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Dec 24, 2020
@TomShawn TomShawn requested a review from hicqu December 25, 2020 03:46
@TomShawn TomShawn added the v5.0 This PR/issue applies to TiDB v5.0. label Dec 25, 2020
TomShawn
TomShawn reviewed Dec 25, 2020
View reviewed changes
garbage-collection-configuration.md Outdated Show resolved Hide resolved
garbage-collection-configuration.md Outdated Show resolved Hide resolved
@ti-srebot
Copy link
Contributor

@hicqu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Dec 25, 2020
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Dec 25, 2020
TomShawn
TomShawn approved these changes Dec 25, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 25, 2020
@ti-srebot
Copy link
Contributor

@TomShawn, @hicqu, PTAL.

@ti-srebot
Copy link
Contributor

@CharLotteiu, please update your pull request.

TomShawn
TomShawn approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn merged commit b4eaf63 into pingcap:master Dec 28, 2020
@morgo morgo mentioned this pull request Jan 6, 2021
Merged
@CharLotteiu CharLotteiu deleted the gc-5.0-changes branch July 9, 2021 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hicqu hicqu hicqu approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CharLotteiu @ti-srebot @hicqu @TomShawn