Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link-check.yaml: filter one false external broken link #5041

Merged
merged 5 commits into from
Mar 17, 2021
Merged

link-check.yaml: filter one false external broken link #5041

merged 5 commits into from
Mar 17, 2021

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Mar 16, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

  • Filter one false external broken link
  • Correct a broken link in connectors-and-apis.md according to docs-cn.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-cherry-pick-5.0 labels Mar 16, 2021
@ti-chi-bot ti-chi-bot requested a review from yikeke March 16, 2021 04:08
@ti-chi-bot ti-chi-bot added translation/no-need No need to translate this PR. status/PTAL This PR is ready for reviewing. and removed missing-translation-status This PR does not have translation status info. labels Mar 16, 2021
TomShawn
TomShawn commented Mar 16, 2021
View reviewed changes
connectors-and-apis.md Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • yikeke

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 16, 2021
@yikeke yikeke merged commit 108fa14 into pingcap:master Mar 17, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 17, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5041 to release-2.1
7484fdd 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 17, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #5050

@TomShawn TomShawn deleted the filter0false/-broken branch March 17, 2021 04:15
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 17, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5041 to release-3.0
ca22a88 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 17, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #5051

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 17, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5041 to release-3.1
cbd6586 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 17, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #5052

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 17, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5041 to release-4.0
31bcbf0 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 17, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5053

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 17, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5041 to release-5.0
ff1fe30 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 17, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5054

ti-chi-bot pushed a commit that referenced this pull request Mar 17, 2021
@ti-srebot
link-check.yaml: filter one false external broken link (#5041) (#5050)
6de260c
ti-chi-bot pushed a commit that referenced this pull request Mar 17, 2021
@ti-srebot
link-check.yaml: filter one false external broken link (#5041) (#5051)
baf9ca7
ti-chi-bot pushed a commit that referenced this pull request Mar 17, 2021
@ti-srebot
link-check.yaml: filter one false external broken link (#5041) (#5052)
ea7ee62
ti-chi-bot pushed a commit that referenced this pull request Mar 17, 2021
@ti-srebot
link-check.yaml: filter one false external broken link (#5041) (#5054)
77bfae2
ti-chi-bot pushed a commit that referenced this pull request Mar 17, 2021
@ti-srebot
link-check.yaml: filter one false external broken link (#5041) (#5053)
e6959e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yikeke yikeke yikeke approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomShawn @ti-chi-bot @ti-srebot @yikeke