Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TiDB v5.4 release notes #7430

Merged
merged 31 commits into from
Feb 15, 2022
Merged

Add TiDB v5.4 release notes #7430

merged 31 commits into from
Feb 15, 2022

Conversation

TomShawn
Copy link
Contributor

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • dveeden

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 19, 2022
TomShawn
TomShawn commented Jan 19, 2022
View reviewed changes
releases/release-5.4.0.md Outdated Show resolved Hide resolved
shichun-0415
shichun-0415 reviewed Jan 19, 2022
View reviewed changes
releases/release-5.4.0.md Outdated Show resolved Hide resolved
releases/release-5.4.0.md Outdated Show resolved Hide resolved
releases/release-5.4.0.md Outdated Show resolved Hide resolved
releases/release-5.4.0.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 20, 2022
@TomShawn TomShawn added v5.4 This PR/issue applies to TiDB v5.4. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jan 21, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jan 21, 2022
@TomShawn TomShawn mentioned this pull request Jan 21, 2022
Merged
14 tasks
sunzhaoyang
sunzhaoyang reviewed Jan 21, 2022
View reviewed changes
Copy link
Contributor

@sunzhaoyang sunzhaoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@IANTHEREAL
Copy link
Contributor

Rest LGTM

@dveeden
Copy link
Contributor

dveeden commented Feb 3, 2022

Shouldn't the removal of cdclog be mentioned? This feature wasn't GA, so removing this without first really deprecating it clearly is fine, but users should know about when reading the release notes.

pingcap/tiflow#3599

dveeden
dveeden reviewed Feb 7, 2022
View reviewed changes
releases/release-5.4.0.md Outdated Show resolved Hide resolved
@TomShawn @dveeden
address comment
dd2e333 
Co-authored-by: Daniël van Eeden <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 7, 2022
@TomShawn TomShawn added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Feb 11, 2022
TomShawn
TomShawn commented Feb 14, 2022
View reviewed changes
releases/release-5.4.0.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Feb 14, 2022
View reviewed changes
releases/release-5.4.0.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Feb 14, 2022
View reviewed changes
releases/release-5.4.0.md Outdated Show resolved Hide resolved
TomShawn
TomShawn commented Feb 15, 2022
View reviewed changes
releases/release-5.4.0.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor Author

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 15, 2022
shichun-0415
shichun-0415 approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bff9f3b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 15, 2022
@ti-chi-bot ti-chi-bot merged commit bdd416d into pingcap:master Feb 15, 2022
@TomShawn TomShawn deleted the 5.4-release-notes branch February 15, 2022 02:17
This was referenced Feb 15, 2022
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7570.

TomShawn added a commit that referenced this pull request Feb 15, 2022
@ti-chi-bot @TomShawn
@shichun-0415 @sunzhaoyang @IANTHEREAL @qqqdan @qiancai @dveeden
Add TiDB v5.4 release notes (#7430) (#7570)
8677008 
* Add TiDB v5.4 release notes

* Update releases/release-5.4.0.md

* Apply suggestions from code review

* update basic feature and experimental features

* update according to google docs

* delete raft engine and add dm doc statement

* Update experimental-features.md

* Update releases/release-5.4.0.md

Co-authored-by: sunzy <[email protected]>

* Apply suggestions from code review

Co-authored-by: Ian <[email protected]>

* add back raft engine

* Update releases/release-5.4.0.md

Co-authored-by: shichun-0415 <[email protected]>

* Apply suggestions from code review

Co-authored-by: Grace Cai <[email protected]>

* fix link

* fix jenkins

* fix

* Apply suggestions from code review

* fix broken anchors

* add snap-generator-pool-size

* fix anchors

* bump version for pd

* remove tidb dashboard root

* fix anchor

* mention the removal of pitr and cdclog

* address comment

Co-authored-by: Daniël van Eeden <[email protected]>

* minor wording change

* change date

* Update releases/release-timeline.md

Co-authored-by: TomShawn <[email protected]>
Co-authored-by: shichun-0415 <[email protected]>
Co-authored-by: sunzy <[email protected]>
Co-authored-by: Ian <[email protected]>
Co-authored-by: qqqdan <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
Co-authored-by: Daniël van Eeden <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai left review comments

@IANTHEREAL IANTHEREAL IANTHEREAL left review comments

@moyun moyun moyun left review comments

@sunzhaoyang sunzhaoyang sunzhaoyang left review comments

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@dveeden dveeden dveeden approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.4 This PR/issue applies to TiDB v5.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@TomShawn @ti-chi-bot @IANTHEREAL @CLAassistant @shichun-0415 @dveeden @sunzhaoyang @moyun @qiancai @qqqdan