Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update doc for memory management of prepared plan cache #8749

Merged
merged 3 commits into from
Jun 6, 2022
Merged

update doc for memory management of prepared plan cache #8749

merged 3 commits into from
Jun 6, 2022

Conversation

ran-huang
Copy link
Contributor

What is changed, added or deleted? (Required)

As title. Some contents are updated in #8689.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ran-huang ran-huang added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. v6.1 This PR/issue applies to TiDB v6.1. labels May 27, 2022
@ran-huang ran-huang requested review from qw4990 and hfxsd May 27, 2022 12:35
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 27, 2022
@ran-huang
fix anchor
eb69ccb 
Signed-off-by: Ran <[email protected]>
@ran-huang ran-huang requested review from Oreoxmt and removed request for hfxsd May 30, 2022 05:57
Oreoxmt
Oreoxmt reviewed Jun 2, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

grafana-tidb-dashboard.md Outdated Show resolved Hide resolved
sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
@ran-huang ran-huang requested a review from Oreoxmt June 2, 2022 13:19
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 6, 2022
qw4990
qw4990 approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang
Copy link
Contributor Author

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 6, 2022
@ran-huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8442b0b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 6, 2022
@ti-chi-bot ti-chi-bot merged commit b2d1612 into pingcap:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.1 This PR/issue applies to TiDB v6.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ran-huang @ti-chi-bot @qw4990 @Oreoxmt