Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add json quote #894

Merged
merged 1 commit into from
Feb 15, 2019
Merged

sql: add json quote #894

merged 1 commit into from
Feb 15, 2019

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Feb 13, 2019

Recently added in pingcap/tidb#7832

Applies to 3.0

@morgo morgo added the v3.0 label Feb 13, 2019
zz-jason
zz-jason reviewed Feb 13, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgo morgo requested a review from lilin90 February 13, 2019 15:32
@morgo
Copy link
Contributor Author

morgo commented Feb 13, 2019

PTAL @lilin90

lilin90
lilin90 approved these changes Feb 15, 2019
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit b633a10 into master Feb 15, 2019
@lilin90 lilin90 deleted the morgo/json-quote branch February 15, 2019 03:51
yikeke pushed a commit to yikeke/docs-cn that referenced this pull request Feb 18, 2019
sql: add JSON QUOTE and fix JSON UNQUOTE
a5b7c27 
Via: pingcap/docs#894
@yikeke yikeke mentioned this pull request Feb 18, 2019
Merged
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@lilin90 lilin90 lilin90 approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@morgo @zz-jason @lilin90 @sre-bot