Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

*: reduce dumpling accessing database and information_schema usage to improve its stability (#305) #315

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #305

What problem does this PR solve?

fix #298 and fix #296 and fix #310

What is changed and how it works?

  1. Try to dump the whole table directly if we meet some errors when we try to split tables into several chunks. cfb258a

  2. Reduce accessing SelectedField and SelectedLen info from database d3ba1e8

  3. Remove the usage of information_schema 1a0d9c4, 7f7cf58, b333bea, 088b5ba, 7dac228, bdb3c26

  4. Fix the bug that dumpling finishedRows is not accurate if we retry in chunks. ff398a4

  5. Fix the bug that dumpling dumps unlocked tables for consistency lock 7f7cf58

  6. Fix the bug of no-schema argument's wrong output 09d257d

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release note

  • reduce dumpling accessing database and information_schema usage and improve dumpling's stability

Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer approved (LGTM1) label Jul 16, 2021
@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 972a640

@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot merged commit d5e0fd0 into pingcap:release-5.1 Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants