-
Notifications
You must be signed in to change notification settings - Fork 85
*: reduce dumpling accessing database and information_schema usage to improve its stability (#305) #315
*: reduce dumpling accessing database and information_schema usage to improve its stability (#305) #315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 972a640
|
/merge |
This is an automated cherry-pick of #305
What problem does this PR solve?
fix #298 and fix #296 and fix #310
What is changed and how it works?
Try to dump the whole table directly if we meet some errors when we try to split tables into several chunks. cfb258a
Reduce accessing
SelectedField
andSelectedLen
info from database d3ba1e8Remove the usage of
information_schema
1a0d9c4, 7f7cf58, b333bea, 088b5ba, 7dac228, bdb3c26Fix the bug that dumpling
finishedRows
is not accurate if we retry in chunks. ff398a4Fix the bug that dumpling dumps unlocked tables for consistency lock 7f7cf58
Fix the bug of
no-schema
argument's wrong output 09d257dCheck List
Tests
Side effects
Related changes
Release note